Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing features in the LCPService API #146

Open
2 of 4 tasks
mickael-menu-mantano opened this issue Dec 9, 2019 · 0 comments
Open
2 of 4 tasks

Missing features in the LCPService API #146

mickael-menu-mantano opened this issue Dec 9, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@mickael-menu-mantano
Copy link
Contributor

mickael-menu-mantano commented Dec 9, 2019

A few features are missing currently in the LCPService:

  • Retrieving the LCPLicense object from a LCPL or JSON.
  • Importing a publication from a license's JSON directly, instead of a LCPL file on the file storage.
  • Pre-load one or more user passphrases in the LCP database. (Various API improvements r2-lcp-swift#97)
  • Having access to the LCPLicense after calling importPublication (in the LCPImportedPublication)

To avoid multiplying the functions, we can add something like this:

extension LCPLicenseSource {
    case lcpl(URL)
    case publication(URL)
    case json(String)
}

func importPublication(from source: LCPLicenseSource, ...)
func retrieveLicense(from source: LCPLicenseSource, ...)
@HadrienGardeur HadrienGardeur added the enhancement New feature or request label Jan 29, 2020
@mickael-menu mickael-menu transferred this issue from readium/r2-lcp-swift Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants