Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Range" CFI with singular text offset terminus step is treated as an "Element" CFI #294

Closed
jccr opened this issue Apr 29, 2016 · 1 comment

Comments

@jccr
Copy link
Contributor

jccr commented Apr 29, 2016

  1. Example Range CFI with a start and end offset: /6/14!/4,/2/14/1:4,/2/16/1:7
  2. Example CFI with a single text terminus: /6/14!/4/2/14/1:4

Bug: CFI 2 is treated as /6/14!/4/2/14/1
Expected: CFI 2 should be used with the text offset

A PR with a fix is in the works by me

CFI library doesn't need changes as it provides the utilities to do this for the readium layer

@jccr
Copy link
Contributor Author

jccr commented Jul 10, 2017

Note to self: Verify this is fixed in upcoming PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants