Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video playback controls not working correctly #187

Closed
rkwright opened this issue Sep 1, 2014 · 12 comments
Closed

Video playback controls not working correctly #187

rkwright opened this issue Sep 1, 2014 · 12 comments

Comments

@rkwright
Copy link
Contributor

rkwright commented Sep 1, 2014

Video playback controls are not working correctly. Some controls will not appear until the page is somehow refreshed (page forward then back), others disappear when the video is started and won't re-appear until the video is finished. These problems can be see in the TestSuite 100 (or SmokeTestFXL).
The problems began after this build on 25 August
rce-a-20140825
And before this build on Friday, 29 August
rce-a-20140829
The 25 August build was right after this commit:
281e239
The 29 August build was after this commit:
c6ea4e0

@rkwright rkwright added this to the v1 milestone Sep 1, 2014
@rkwright
Copy link
Contributor Author

rkwright commented Sep 1, 2014

It would appear that it was the commit for the next/prev button issue.I synched my copy of all three repos to the commit hashes shown above for 25 August and rebuilt. Seemed to work fine. I then synched to the next commit (in each repo) which was the set of 3 commits of the Lars->Dmitry work (merged by Ryan on 27 August) to hide the next/prev buttons when there was no page (issue #117).
The resulting build had these commit hashes:
rca-20140827
When I first pulled from these hashes, I rebuilt and got a hang (forever spinner). This also happened when I first synched to test the next/prev feature (on 27 August). The about box was clean. I was then advised to enter 'grunt update-readium' That DID fix the issue (then and now) but notice that the about box now says "Local changes". I guess the update-readium command changed something.
In any case, the resulting build works, but exhibits the problems with the video controls.

@danielweck
Copy link
Member

@danielweck
Copy link
Member

FYI, I have always been able to reproduce "weird" video interaction / rendering bugs when in the 1+ CSS columns, but that's a separate issue:
readium/readium-shared-js#54

@danielweck
Copy link
Member

@rkwright I have synch'ed my git checkouts to (as per your screenshot above for August 25th revisions):

js-viewer:
281e239
281e239

readium-js
8bbfbd70415e70603e19e793259c072a62a67e80
readium/readium-js@8bbfbd7

shared-js
a592f34e09854647dfdac075dedd0f6d8a2dd1e7
readium/readium-shared-js@a592f34

...and I can easily reproduce (Chrome and Safari on OSX) the "weird" interaction / rendering bugs when the video is in any other CSS column than the very first one. This seems to be this known bug:
readium/readium-shared-js#54

@rkwright
Copy link
Contributor Author

rkwright commented Sep 2, 2014

I have not seen this behaviour before in the Chrome extension and it is highly reproducible. Let's discuss at the eng meeting later today.

@danielweck
Copy link
Member

@rkwright weirdly, I can reproduce the bug with the 25th August build too :(
(unlike you, it seems)

@rkwright
Copy link
Contributor Author

rkwright commented Sep 2, 2014

In the Chrome Extension? What platform? I am on OSX 10.9.1, but I'll try it on Windows too

@danielweck
Copy link
Member

Latest Chrome and OSX.

cd readium-js-viewer
git checkout 281e239f7f12c2aa2d48b16ffe3cdd9acd7a2d41

cd readium-js
git checkout 8bbfbd70415e70603e19e793259c072a62a67e80

cd readium-shared-js
git checkout a592f34e09854647dfdac075dedd0f6d8a2dd1e7

grunt update-readium

(1) open epub30-test-0100.epub
(2) navigate TOC "video"
(3) play first column video, pause, change volume, etc. (all okay)
(4) second column video: can't interact
(5) goto next page: videos cannot interact as soon as the first picture (or video poster) is displayed.

Can also reproduce with https://code.google.com/p/epub-samples/downloads/detail?name=cc-shared-culture-20120130.epub see step-by-step here:
readium/readium-shared-js#78

@rkwright
Copy link
Contributor Author

rkwright commented Sep 2, 2014

Just tried it on Windows 7 (under bootcamp on my elderly MacPro) and cannot reproduce this behaviour..

Ha! Update. I just now managed to reproduce it on my MBP. But it's not easy to reproduce with the older build. Happens every time with newer build. Some sort of timing issue? Or?

@danielweck
Copy link
Member

My understanding of issue readium/readium-shared-js#54 is that as soon as the video surface gets rendered over the controls, the whole video becomes inaccessible (mouse interaction, etc.). The video can still be controlled via EPUB triggers (or any other programmatic invocation), it is just the interaction that is messed-up in column 1+

@danielweck
Copy link
Member

Note that although Opera is also based on WebKit, I cannot reproduce the bug. Only Safari and Chrome.
(epub30-test-0100.epub)

@danielweck
Copy link
Member

Closed as a duplicate of readium/readium-shared-js#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants