Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathJAX: after loading, HTML dimensions may have changed (render pass), need to refresh column-pagination #150

Closed
danielweck opened this issue Aug 7, 2014 · 5 comments

Comments

@danielweck
Copy link
Member

...otherwise, the number of pages (columns) is determined based on the HTML dimensions that do not reflect the final render.

@danielweck danielweck added this to the v1 milestone Aug 7, 2014
@danielweck
Copy link
Member Author

Perhaps something along the lines of:

https://github.com/readium/readium-shared-js/blob/develop/js/views/iframe_loader.js#L119

(here, the "done" callback is only invoked upon completion of a timed MathJAX task...but not sure how many equations are rendered exactly)

@danielweck
Copy link
Member Author

Test EPUB:

https://github.com/readium/readium-js-viewer/tree/develop/epub_content/linear-algebra

(some pages are really quite heavy...long wait time before render complete...but I think the column-pagination does not compute the correct number of pages)

@ryanackley
Copy link
Contributor

The 8 second timeout was causing this.

If we are going to have a timeout, we should show an error since pagination would be broken if we tried to continue. I've removed the timeout for now.

@danielweck
Copy link
Member Author

8s timeout removal:
readium/readium-js@626472a

@danielweck
Copy link
Member Author

See readium/readium-shared-js#82 for more information from MathJAX devs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants