Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kindly help me with audioBook.Lcp Failure when come to the end of file. #601

Closed
hishampro5 opened this issue Dec 30, 2024 · 10 comments
Closed
Labels
bug Something isn't working

Comments

@hishampro5
Copy link

Describe the bug

i am developing android app for run audiobooks.lcp ..etc but the issue only encounter with audiobooks (Lcp) when am trying same file on TestApp show me message that is not supported on test app.

The issue :
when audio books run it's works fine but when audioBook finsh the error occurs you can see logs below i am not sure if this happen because readium or something else.

also there are design error when you click on drawer menu twice the back to book the drawer menu items still appear above of book content.

Error Log :
UserError: An error occurred in the ExoPlayer engine. ExoPlayerEngine.Error.Engine: An error occurred in the ExoPlayer engine. ExoPlaybackException: Source error androidx.media3.exoplayer.ExoPlayerImplInternal.handleIoException(ExoPlayerImplInternal.java:717) androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:693) Loader.UnexpectedLoaderException: Unexpected IllegalArgumentException: Failed requirement. androidx.media3.exoplayer.upstream.Loader$LoadTask.run(Loader.java:442) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) IllegalArgumentException: Failed requirement. org.readium.r2.lcp.LcpDecryptor$CbcLcpResource.lengthFromLastTwoBlocks(LcpDecryptor.kt:150) org.readium.r2.lcp.LcpDecryptor$CbcLcpResource.read(LcpDecryptor.kt:236)

How to reproduce?

1- open audioBook (LCP)
2- play the book
3- wait to the end
4- the error occurs

Readium version

3.0.2

Android API version

14

Additional context

No response

@hishampro5 hishampro5 added bug Something isn't working triage Triage needed by maintainers labels Dec 30, 2024
@qnga
Copy link
Member

qnga commented Dec 30, 2024

These definitely look like Readium and testapp bugs, thanks for reporting. Your audiobook is probably guilty, but we should handle this case better. Could you confirm that you don't get this log with every LCP audiobook? I don't get it with a random one.

@qnga qnga removed the triage Triage needed by maintainers label Dec 30, 2024
@hishampro5
Copy link
Author

I'm sorry that this happens with all books of the same type ( Lcp )

also we tried on test app and get same issue Test app download from => https://github.com/readium/kotlin-toolkit/releases/download/3.0.2/test-app-3.0.2.apk

Screenshot_٢٠٢٤-١٢-٣٠-١١-٢٢-٤٨-٩٨٧_org readium r2reader

1735549673936

This is book you can try from your side (Lcp) book =>
Book Link on drive => https://drive.google.com/file/d/1jWTlh5fKTtK_zA5u8mBWmvw2JtR-8cl0/view?usp=sharing
Passphrase => malhadadi139gmailcommalhadadi139

@qnga

@qnga
Copy link
Member

qnga commented Dec 30, 2024

I can reproduce the bug, thanks again!

@hishampro5
Copy link
Author

hishampro5 commented Dec 30, 2024

@qnga sorry sir but Any guess when this might be fixed ; because we are blocked with this issue 🌹

@qnga
Copy link
Member

qnga commented Dec 30, 2024

I'd like to review carefully this piece of code because it's not the first time it's faulty, maybe this week. In the meantime, you can use the lcp-fixes branch if you're in a hurry.

@hishampro5
Copy link
Author

@qnga Hi sir is there any update for this issue.

@qnga
Copy link
Member

qnga commented Jan 6, 2025

I rewrote the code, expect a release in the next few days.

@mickael-menu
Copy link
Member

@hishampro5 Could you confirm that the fix now in main resolves your issue before we do a new release? Thank you

@hishampro5
Copy link
Author

@mickael-menu yes it's working fine with audio books (Lcp) we tested with testApp . Can i know when this might be released

@qnga
Copy link
Member

qnga commented Jan 8, 2025

It's done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants