Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for new LCP Profiles #509

Closed
llemeurfr opened this issue May 6, 2024 · 0 comments · Fixed by #510
Closed

[Feature] Add support for new LCP Profiles #509

llemeurfr opened this issue May 6, 2024 · 0 comments · Fixed by #510
Labels
bug Something isn't working triage Triage needed by maintainers

Comments

@llemeurfr
Copy link

Describe the bug

New LCP Profiles are appearing, embedded in the LCP precompiled library. The Kolin code contains a filter on the profiles allowed and this filter must now be extended in the 2.x version of the toolkit.

nb: a smarter solution will be adopted in the 3.x version of the toolkit.

How to reproduce?

Please make adjustments to the Readium Kotlin Toolkit by adding new values to supportedProfiles.
in
https://github.com/readium/kotlin-toolkit/blob/develop/readium/lcp/src/main/java/org/readium/r2/lcp/license/LicenseValidation.kt#L38

Values are in the form
"http://readium.org/lcp/profile-2.0",
to
"http://readium.org/lcp/profile-2.9",

Readium version

2.7

Android API version

x

Additional context

No response

@llemeurfr llemeurfr added bug Something isn't working triage Triage needed by maintainers labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Triage needed by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant