Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow performance when changing appearance settings with Cyrillic fonts #167

Closed
RomanSoviak opened this issue Jun 26, 2020 · 9 comments
Closed

Comments

@RomanSoviak
Copy link

oryel_1984.zip
Hi! Thanks for the great SDK. I tried to open this book, but working with that has bad performance. For example on Windows, iOS this book opening fine. I don't know where the issue is.

@RomanSoviak
Copy link
Author

@mickael-menu
Copy link
Member

I didn't notice any significant performance issue on a Pixel 3a. Sometimes a chapter takes too long (~2 s) to initially render – maybe because of the Cyrillic font? – but no issues turning pages.

However I noticed that the columns get shifted when swiping:

Screenshot_20200629-101320

@RomanSoviak
Copy link
Author

photo_2020-06-30_14-21-56

@RomanSoviak
Copy link
Author

@mickael-menu thanks for the quick response. Sometimes I have this issue.

@RomanSoviak
Copy link
Author

@mickael-menu It works slowly when I change settings(Size of font, ...)

@RomanSoviak
Copy link
Author

@mickael-menu
Copy link
Member

Thanks for taking the time to make a video. I can reproduce the issue too when changing the font sizes.

Like you mentioned in this other issue: readium/r2-testapp-kotlin#334, I think it's related to the Cyrillic fonts. Unfortunately, I'm not sure we can improve much in Readium, because we're using the native WebView for the rendering on Android.

@JayPanoz Do you think it's something that could potentially be improved in Readium CSS or no luck? Maybe we could have a lighter but less reliable way of changing the font size for such cases?

@mickael-menu mickael-menu changed the title Very slow performance during working with book Slow performance when changing appearance settings with Cyrillic fonts Jul 1, 2020
@JayPanoz
Copy link

JayPanoz commented Jul 1, 2020

That’s a good question, I’m assuming we may potentially encounter similar issues with CJK – I know some other apps take ages e.g. 10 seconds for Japanese in vertical writing for instance.

My gut feeling tells me to check HarfBuzz issues to possibly find some leads (this is the lib Android/Chromium is using for text shaping) but it might be anything on top of it. Also reminds me of @danielweck’s performance issues a few months ago in Electron – massive area to paint – so that could be another lead.

@mickael-menu
Copy link
Member

I'm closing this because it is not clear we can fix this issue in Readium. Feel free to continue the discussion if you have some insights in how we could address it.

@mickael-menu mickael-menu transferred this issue from readium/r2-navigator-kotlin Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants