Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X Launcher needs to support the new ContentFilter errors #45

Open
nleme opened this issue Aug 13, 2015 · 0 comments
Open

OS X Launcher needs to support the new ContentFilter errors #45

nleme opened this issue Aug 13, 2015 · 0 comments

Comments

@nleme
Copy link

nleme commented Aug 13, 2015

Recently, I modified the Readium SDK and the iOS and Android Launchers to support ContentFilter errors. Basically, I created a new architecture so that the ContentFilters can report that they had an error when trying to filter bytes from a given resource.

In the iOS and Android Launchers, that error will bubble all the way up to the app, so that the app can display or log something about the given error. The idea is that people using the Readium SDK in their iOS and Android apps can copy the code to deal with their own ContentFilter errors.

However, I have not done so for the OS X Launcher. Presently, I do not have the time to do that, so it would be up to somebody who has the time to modify the OS X Launcher so that it will receive ContentFilter errors and potentially do something with them (like displaying a message or writing a log).

It should not be a difficult task, basically the person doing this would just have to do something very similar to what I did for iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants