New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not close channel in RpcClient #92

Closed

acogoluegnes opened this issue Jun 17, 2019 · 0 comments

Assignees

Labels

effort-low type/bug

Milestone

Contributor

acogoluegnes commented Jun 17, 2019 •

edited

Loading

The RpcClient does not handle the lifecycle of the channel that it uses, so it should not close it.

The text was updated successfully, but these errors were encountered:

acogoluegnes added type/bug effort-low labels

acogoluegnes added this to the 1.3.0 milestone

acogoluegnes self-assigned this

acogoluegnes changed the title ~~Do not close channel in RpcClient~~ Close channel in RpcClient#close

acogoluegnes changed the title ~~Close channel in RpcClient#close~~ Do not close channel in RpcClient

acogoluegnes closed this as completed in

b11daa4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment