Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to specify Consumer Arguments in Receiver.consume* methods #165

Closed
maciejharczuk opened this issue Oct 26, 2021 · 3 comments
Closed
Labels
good first issue Ideal for a new contributor, we'll help type/enhancement A general enhancement

Comments

@maciejharczuk
Copy link

It looks like it's not possible to specify Consumer arguments when using any of the Receiver's consume* methods. I'm not sure if there was any use for them in the past, but with RabbitMQ 3.9 streams, if consuming them with AMQP client, the x-stream-offset argument is used to specify the offset at which consumption will start.

Since we already have the ability to pass ConsumeOptions to Receiver.consume* methods, I suggest we add an empty-by-default (or null) map of args to that class, so that later we can pass it to channel.basicConsume.

@acogoluegnes acogoluegnes added good first issue Ideal for a new contributor, we'll help type/enhancement A general enhancement labels Oct 27, 2021
@latuszek
Copy link

@acogoluegnes, is there a plan to release this any time soon?

@acogoluegnes
Copy link
Contributor

It's in 1.5.4 and 1.4.8.RELEASE.

@latuszek
Copy link

OK, I must have missed it because of the not updated releases page. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for a new contributor, we'll help type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants