react-reconciler: README host config links resolve to 404

[aidenybai]

The host config links for React DOM resolve to 404: https://www.npmjs.com/package/react-reconciler

[aidenybai]

I'm not sure whether this goes under this repo as a docs issue or react as a bug

[ArslanYM]

Its working

[aidenybai]

correction* just for React DOM

[gaearon]

Can you please be more specific? Which link is 404?

[aidenybai]

Sorry about that, here is the steps for reproduction:

1. Go to npmjs.com/package/react-reconciler
2. Go under the Practical Examples section and look for host configs:

3. Click on the `host config` link for React DOM (Broken link: https://github.com/facebook/react/blob/main/packages/react-dom/src/client/ReactDOMHostConfig.js)

[ArslanYM]

Can i work on this ?

[ArslanYM]

please

[ArslanYM]

@aidenybai What should this link be pointing to? Since the current link doesnt exist

[aidenybai]

I'm not actually sure... I haven't been able to find the actual host config for React DOM myself

[gaearon]

It's in the React repo: https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactDOMHostConfig.js. You can similarly search for other files by name. If you'd like, please send a fix to the README.md in packages/react-reconciler/ in the React repo.

[ArslanYM]

It's in the React repo: https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactDOMHostConfig.js. You can similarly search for other files by name. If you'd like, please send a fix to the README.md in packages/react-reconciler/ in the React repo.

Can you please assist me on what change should be exactly made to the Readme.MD file in packages/react-reconciler/ in the facebook/React repo

[harish-sethuraman]

It has correct link in the readme for react-dom host config? The readme in npm registry doesnt seem to reflect it?

https://github.com/facebook/react/blob/4a1cc2ddd035f5c269e82ab6f7686e2e60d3b3ea/packages/react-reconciler/README.md?plain=1#L61

[roy9495]

the issue is fixed in this pr facebook/react#26592

[roy9495]

the issue is fixed in this pr facebook/react#26592

The updated Readme.md https://github.com/facebook/react/tree/main/packages/react-reconciler

[aidenybai]

awesome, great work @roy9495

[roy9495]

awesome, great work @roy9495

Thank You