Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React 16 Support #199

Closed
emilyrohrbough opened this issue Sep 26, 2017 · 2 comments
Closed

Add React 16 Support #199

emilyrohrbough opened this issue Sep 26, 2017 · 2 comments

Comments

@emilyrohrbough
Copy link

emilyrohrbough commented Sep 26, 2017 •
edited
Loading

Feature Request

react-transition-group provides support for react v^15.0.0. React 16 is expected to be released soon and can currently be tested with react 16.0.0-rc (more information can be found on facebook/react#10294).

react-transition-group is a dependency in a package in the terra-core monorepo, which will need to be React 16 compatible. From my initial assessment of our repository, it seems focus-trap behaves as expected with react v16.0.0-rc, but confirmed testing is needed.
@taion
Copy link
Member

taion commented Sep 26, 2017

already have a PR in #198

@taion taion closed this as completed Sep 26, 2017
@emilyrohrbough emilyrohrbough mentioned this issue Sep 26, 2017
Closed
4 tasks
@lukeapage
Copy link

@taion please can this be backported to v1 ? We have to use v1 because of velocity-react..
google-fabric/velocity-react#224

@luisrudge luisrudge mentioned this issue Feb 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lukeapage @taion @emilyrohrbough