Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dialog element #212

Closed
gavmck opened this issue Aug 18, 2016 · 6 comments
Closed

Use dialog element #212

gavmck opened this issue Aug 18, 2016 · 6 comments

Comments

@gavmck
Copy link

gavmck commented Aug 18, 2016

Could this make use of the dialog element for greater accessibility?

http://www.w3schools.com/tags/tag_dialog.asp
@diasbruno
Copy link
Collaborator

@gavmck It would be nice, but it seems to be implemented in a few browsers...
There is an attribute role=dialog, maybe it can be useful for now.

Sources:
MDN - Dialog
caniuse.com/dialog

@NickHeiner
Copy link

Yes, you should be putting role="dialog" on the modal element. That will assist screen readers by letting them understand the semantic role of the element in the app.

claydiffrient added a commit that referenced this issue Sep 14, 2016
@claydiffrient
[added] Make modal portal have the dialog role
e389d65 
closes #212
@claydiffrient claydiffrient mentioned this issue Sep 14, 2016
Merged
5 tasks
claydiffrient added a commit that referenced this issue Sep 21, 2016
@claydiffrient
[added] Make modal portal have the dialog role (#223)
2e806c7 
closes #212
@NickHeiner
Copy link

Nice!

@OliverJAsh
Copy link
Contributor

Fast forward 7 years, the dialog element now has good support. Can we re-open this?

@OliverJAsh OliverJAsh mentioned this issue Mar 29, 2023
Open
@gavmck
Copy link
Author

gavmck commented Mar 29, 2023

@OliverJAsh That would be great 🚀

@jaxor24
Copy link

jaxor24 commented Dec 13, 2023

Also keen for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@diasbruno @gavmck @NickHeiner @OliverJAsh @jaxor24