You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
v15 and v16 were released in 2017 (seven years ago) and v0.14.0 is from 2015 (nine years ago).
It seems fair to drop at least v0.14.0 and v15 in the next major release for react-modal. (To be explicit at the risk of being pedantic, updating peer dependencies is generally considered a breaking change... even when the peer dependencies are ancient.) 😃
Dropping support for React v16 seems reasonable too, though it may be nice to support that one through v4 if we feel there are time/resources to do so.
Note that #1019 raises some issues with react-modal compatibility with React v18. These are particularly tricky as it'll require some care to ensure the fixes work for v17.
The text was updated successfully, but these errors were encountered:
Currently, the package.json file notes the following React peer dependencies:
v15 and v16 were released in 2017 (seven years ago) and v0.14.0 is from 2015 (nine years ago).
It seems fair to drop at least v0.14.0 and v15 in the next major release for react-modal. (To be explicit at the risk of being pedantic, updating peer dependencies is generally considered a breaking change... even when the peer dependencies are ancient.) 😃
Dropping support for React v16 seems reasonable too, though it may be nice to support that one through v4 if we feel there are time/resources to do so.
Note that #1019 raises some issues with react-modal compatibility with React v18. These are particularly tricky as it'll require some care to ensure the fixes work for v17.
The text was updated successfully, but these errors were encountered: