Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add Shell navigation Support for Xamarin.Forms #2304

Closed
RLittlesII opened this issue Jan 6, 2020 · 2 comments
Closed

feature: Add Shell navigation Support for Xamarin.Forms #2304

RLittlesII opened this issue Jan 6, 2020 · 2 comments

Comments

@RLittlesII
Copy link
Member

Is your feature request related to a problem? Please describe.

This is a request for Xamarin.Forms Shell Support.

Describe the solution you'd like

ReactiveUI to support Xamarin.Forms Shell as opposed to the current INavigation interface. This will introduce an entirely new paragadim into ReactiveUI for navigation and make the current RoutingState obsolete in Shell applications. The new Shell navigation will be specific to the Xamarin.Forms platform.

Describe alternatives you've considered

None. There is a perfectly convenient routing system in Xamarin Forms that ReactiveUI supports. But it doesn't support Shell. Currently you have to choose between Xamarin.Forms Shell or ReactiveUI Routing. The current ReactiveUI routing system will not support shell out of the box.

NOTE

There is currently some work the Xamarin.Forms team is doing to support MVVM with Shell. Last I was told that work is being tracked here xamarin/Xamarin.Forms#5166

Describe suggestions on how to achieve the feature

An abstraction over the Shell to make it less static and more in line with MVVM patterns. Not sure the specifics of what this looks like.

Additional context

The Xamarin.Forms Shell approach is a Page => Page approach. ReactiveUI has been actively trying to move to the ViewModel based navigation. These two concepts are not congruent with each other, this doesn't mean they won't work together. This simply means that we will have to work to address concerns in our approach to get the most value.

@open-collective-bot
Copy link

Hey @RLittlesII 👋,

Thank you for contributing to our project financially. We will handle your issue with priority support. To make sure we don't forget how special you are, we added a priority label to your issue.

Thank you again for contributing 🎉!

@ChrisPulman ChrisPulman changed the title feature: Add Shell Support for Xamarin.Forms feature: Add Shell navigation Support for Xamarin.Forms Aug 6, 2021
@ChrisPulman ChrisPulman self-assigned this Aug 6, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants