Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code out of MD files #126

Closed
mkiedys opened this issue Oct 15, 2014 · 7 comments
Closed

Move code out of MD files #126

mkiedys opened this issue Oct 15, 2014 · 7 comments
Milestone

Comments

@mkiedys
Copy link

mkiedys commented Oct 15, 2014

This is follow-up from PR #125:

@viktorklang wrote:
(...) what I meant was that I think that sample code should live in compiled files, so that we can catch when it needs to be updated. As such I think all code should be moved out of .mds and put into files and then either imported automatically into the .mds or be linked from the .mds.

@ktoso
Copy link
Contributor

ktoso commented Nov 19, 2014

I was looking into this today and sadly github is still working on securing markup includes github/markup#172 (comment) and it is currently not possible to do without pre-processing.

@rkuhn
Copy link
Member

rkuhn commented Jan 16, 2015

Checking: no change on the github side of things. This is a generic ticket with possibly a different solution, so if somebody has a low-overhead working principle to point at then we should definitely try it out.

@viktorklang
Copy link
Contributor

I think we should just link to the example files or the spec classes (now with Java they have their own files).

@ktoso
Copy link
Contributor

ktoso commented Mar 30, 2015

@reactive-streams @viktorklang so are we planning on doing something with this now?
Tech wise the situation has not changed, we can't include files.

@viktorklang
Copy link
Contributor

I think this will stay as a "nice-to-have".

@ktoso
Copy link
Contributor

ktoso commented Mar 30, 2015

Sounds good to me.

@viktorklang
Copy link
Contributor

I don't think there's enough need to warrant this Issue. If someone disagrees, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants