Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate ESLint Warnings #5284

Closed
spencern opened this issue Jul 8, 2019 · 1 comment
Closed

Eliminate ESLint Warnings #5284

spencern opened this issue Jul 8, 2019 · 1 comment
Labels
epic For issues that exist only to track progress on a list of other issues in one place

Comments

@spencern
Copy link
Contributor

spencern commented Jul 8, 2019

Reaction currently has 760 warnings from our linter - ESLint.
We'd like to start enforcing that new PRs have 0 lint errors or warnings, but we have hundreds of warnings in the app currently that need to be resolved.

image
@spencern spencern added the epic For issues that exist only to track progress on a list of other issues in one place label Jul 8, 2019
@kieckhafer kieckhafer mentioned this issue Aug 13, 2019
Merged
@kieckhafer
Copy link
Member

Resolved via #5450 (and many other PR's, but that was the final one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic For issues that exist only to track progress on a list of other issues in one place
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spencern @kieckhafer