Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL: Navigation items content resolver shouldn't filter array by language #4912

Closed
dancastellon opened this issue Jan 10, 2019 · 1 comment
Closed

GraphQL: Navigation items content resolver shouldn't filter array by language #4912

dancastellon opened this issue Jan 10, 2019 · 1 comment
Assignees
@dancastellon

Comments

@dancastellon
Copy link
Contributor

dancastellon commented Jan 10, 2019 •
edited
Loading

Issue Description

Discussion here: reactioncommerce/example-storefront#472 (comment)

Essentially, the content array of a navigation item shouldn't be filtered down by language. Instead we should have a separate contentForLanguage: String resolver.
@dancastellon dancastellon self-assigned this Jan 10, 2019
@dancastellon dancastellon mentioned this issue Jan 10, 2019
Merged
@kieckhafer
Copy link
Member

Closed by #4913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dancastellon dancastellon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dancastellon @kieckhafer