[Bug] NaN Undefined on Store with Very Large Integers

[jeffcorpuz]

Issue Description

When declaring a product's price more than 3 significant figures (1 x 10 ^ 3), NaN Undefined results up on the Store.

Where as when in the product's detailed page, the real price will be shown.

Note: Does not matter if the Compare At Price is very large

Examples :

Steps to Reproduce

Please provide starting context, i.e. logged in as a user, configure a particular payment method.

1. Create/Edit existing product's "Price" to have more than 3 significant figures, i.e. 1000, 10000 etc.
2. Go to storefront page, to see visual NaN

Versions

2.0.0-release-rc.8

[spencern]

@jeffcorpuz nice find. Is this a regression introduced in rc.8?

[jeffcorpuz]

@spencern going through tags checkouts, seems it is introduced between rc.5(f9fd923) and rc.6(b49fbf0).

[spencern]

@kieckhafer can you take a look at this?

[kieckhafer]

Looks like this is only for logged in Admin users, non-admin / logged out users see the correct number

vs

[kieckhafer]

So it looks like this breaks for us inside of accounting.formatMoney: https://github.com/reactioncommerce/reaction/blob/feat-kieckhafer-surcharges/client/modules/i18n/currency.js#L159

And it seems that it has something to do with the us using String as the type for saving price range, and the comma (,) that we save in the database when the price is over $1000. (We save as 1,000). When I manually remove the comma(s) from the database, it works fine.

However, it still displays fine in the side bar, even with the commas inside the database - although they are coming from the Catalog collection, where as the errored version is coming from the Products collection:

The solution is probably to try and save the strings without a comma in them - although still trying to figure out why the Products and Catalog collection seems to behave differently.

[kieckhafer]

Closed via #4910 and #4916