Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRC nick beginning with ? gets rendered as {$author} #361

Closed
DankRank opened this issue Feb 4, 2018 · 3 comments
Closed

IRC nick beginning with ? gets rendered as {$author} #361

DankRank opened this issue Feb 4, 2018 · 3 comments

Comments

@DankRank
Copy link

DankRank commented Feb 4, 2018

ZNC bouncer has a module which allows ZNC users chat with eachother even if they are connected to different networks. It's effectively an ircd inside a bouncer. The side-effect is that all nicknames are prefixed with question mark.

The template doesn't get replaced properly by discord-irc, so such nick is displayed as {$author} in Discord.

Needless to say, this bug is low priority, as normal ircds won't allow question marks in nicknames.

@Throne3d
Copy link
Collaborator

Throne3d commented Mar 3, 2018

I expect this is down to the upstream IRC library failing to parse the nickname in the message string, so it's mostly a bug with irc-upd – I've created an issue for this here and will try to get to it… within the next month? :P

Separately, it might be worth figuring out a fallback, in discord-irc, for if the author's name can't be found. Maybe we should flag it up in the console? I'm not sure what we'd put in the relayed message, though.

@Throne3d
Copy link
Collaborator

This is now fixed upstream, so when a new version of the library is released (and a new version of this, with that in), it'll be fixed.

@Throne3d
Copy link
Collaborator

Throne3d commented Aug 4, 2019

This should've been fixed in irc-upd 0.9.0, and so shouldn't have been a problem in this bot for a while now. Please reopen this if the issue persists (with your discord-irc version)!

@Throne3d Throne3d closed this as completed Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants