feat: allow deep linking to reset state #8973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-navigation-example ready! Built with commit f6f6d2b https://deploy-preview-8973--react-navigation-example.netlify.app |
|
The Expo app for the example from this branch is ready! expo.io/@react-navigation/react-navigation-example?release-channel=pr-8973 |
satya164
force-pushed
the
@satya164/navigate-reset
branch
from
8ca9379 to
becf99a
Compare
Codecov Report
@@ Coverage Diff @@
## main #8973 +/- ##
==========================================
+ Coverage 73.71% 73.98% +0.26%
==========================================
Files 131 131
Lines 3276 3306 +30
Branches 1017 1008 -9
==========================================
+ Hits 2415 2446 +31
- Misses 751 752 +1
+ Partials 110 108 -2
Continue to review full report at Codecov.
|
satya164
force-pushed
the
@satya164/navigate-reset
branch
3 times, most recently
from
99832d8 to
e09bc56
Compare
Currently when we receive a deep link after the app is rendered, it always results in a `navigate` action. While it's ok with the default configuration, it may result in incorrect behaviour when a custom `getStateForPath` function is provided and it returns a routes array different than the initial route and new route pair. The commit changes 2 things: 1. Add ability to reset state via params of `navigate` by specifying a `state` property instead of `screen` 2. Update `getStateForAction` to return an action for reset when necessary according to the deep linking configuration
satya164
force-pushed
the
@satya164/navigate-reset
branch
from
e09bc56 to
f6f6d2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we receive a deep link after the app is rendered, it always results in a
navigateaction. While it's ok with the default configuration, it may result in incorrect behaviour when a customgetStateForPathfunction is provided and it returns a routes array different than the initial route and new route pair.The commit changes 2 things:
navigateby specifying astateproperty instead ofscreengetStateForActionto return an action for reset when necessary according to the deep linking configurationCloses #8952