Preloading for simple navigators - tabs, drawer #11709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Expo app for the example from this branch is ready! |
# Conflicts: # packages/bottom-tabs/src/views/BottomTabView.tsx # packages/drawer/src/views/DrawerView.tsx # packages/material-top-tabs/src/views/MaterialTopTabView.tsx
osdnk
changed the title
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #11709 +/- ##
==========================================
+ Coverage 75.78% 75.98% +0.20%
==========================================
Files 207 207
Lines 6075 6080 +5
Branches 2354 2362 +8
==========================================
+ Hits 4604 4620 +16
+ Misses 1418 1407 -11
Partials 53 53 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a straightforward application of #11702. Now, we implement the behaviour of simple navigators. We refer to the original PR for a detailed motivation.
Additionally, we have tests.
Test plan
The flow is sufficiently covered in the example app.
Screen.Recording.2023-12-03.at.02.21.28.mov