This repository has been archived by the owner on Feb 25, 2020. It is now read-only.
fix: gesture vertical inverted #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osdnk
commented
Nov 4, 2019
| @@ -412,18 +412,25 @@ export default class Card extends React.Component<Props> { | |||
| cond( | |||
| eq(this.props.current, isVisible), | |||
| call( | |||
| [this.didMovementHappen, this.isVisible], | |||
| ([didMovementHappen]: ReadonlyArray<Binary>) => { | |||
| [this.didMovementHappen, isVisible], | |||
There was a problem hiding this comment.
We need to handle a case when we release not components either on the beginning or end of animation
satya164
suggested changes
Nov 5, 2019
| @@ -636,7 +646,10 @@ export default class Card extends React.Component<Props> { | |||
| this.gestureUntraversed, | |||
| I18nManager.isRTL ? MINUS_ONE_NODE : TRUE_NODE | |||
| ), | |||
| this.gestureUntraversed | |||
| multiply( | |||
There was a problem hiding this comment.
Instead of multiplying this in each place, maybe it'll be better to create a single node which multiplies it and reuse that? Like we do for direction
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.