Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

feat: expose animation related properties in context #278

Conversation

chrfalch
Copy link
Contributor

@chrfalch chrfalch commented Oct 30, 2019

This pull request addresses an important shortcoming of the previous PR #183 where the wrong progress value was provided for the first of two screens in a transition.

@satya164, @samchamberland

src/views/Stack/Card.tsx Outdated Show resolved Hide resolved
@chrfalch
Copy link
Contributor Author

chrfalch commented Nov 6, 2019

Was the memoization implemented the way you wanted, @satya164 ?

@satya164
Copy link
Member

satya164 commented Nov 6, 2019

Yea. Thank you!

@satya164 satya164 changed the title fix: correct progress value is exposed in both to/from screens feat: expose animation related properties in context Nov 6, 2019
@satya164 satya164 merged commit e33892a into react-navigation:master Nov 6, 2019
@chrfalch
Copy link
Contributor Author

chrfalch commented Nov 6, 2019

Yea. Thank you!

Np :) This looks super awesome now!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants