This repository has been archived by the owner on Feb 25, 2020. It is now read-only.
fix: add clearTimeout to keyboard manager #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
reviewed
Oct 24, 2019
src/views/KeyboardManager.tsx
Outdated
| @@ -14,6 +14,13 @@ export default class KeyboardManager extends React.Component<Props> { | |||
| // When a gesture didn't change the tab, we can restore the focused input with this | |||
| private previouslyFocusedTextInput: number | null = null; | |||
| private startTimestamp: number = 0; | |||
| private keyboardTimeout: NodeJS.Timer | null = null; | |||
There was a problem hiding this comment.
undefined is good
Suggested change
| private keyboardTimeout: NodeJS.Timer | null = null; | |
| private keyboardTimeout: NodeJS.Timer; |
There was a problem hiding this comment.
private keyboardTimeout: NodeJS.Timeout
src/views/KeyboardManager.tsx
Outdated
|
|
||
| componentWillUnmount = () => { | ||
| if (this.keyboardTimeout !== null) { | ||
| global.clearTimeout(this.keyboardTimeout); |
There was a problem hiding this comment.
Suggested change
| global.clearTimeout(this.keyboardTimeout); | |
| clearTimeout(this.keyboardTimeout); |
There was a problem hiding this comment.
Probably should also clear the time out on beginning of handlePageChangeStart, handlePageChangeConfirm and handlePageChangeCancel in case there is another quick swipe after cancel?
satya164
reviewed
Oct 24, 2019
| @@ -14,8 +14,21 @@ export default class KeyboardManager extends React.Component<Props> { | |||
| // When a gesture didn't change the tab, we can restore the focused input with this | |||
| private previouslyFocusedTextInput: number | null = null; | |||
| private startTimestamp: number = 0; | |||
| private keyboardTimeout: NodeJS.Timeout | undefined; | |||
|
|
|||
| clearKeyboardTimeout = () => { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.