This repository has been archived by the owner on Feb 25, 2020. It is now read-only.
feat: swipe velocity impact as prop #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osdnk
changed the title
osdnk
commented
Oct 5, 2019
Comment on lines
+504
to
+512
| set( | ||
| this.gesture, | ||
| cond( | ||
| eq(this.direction, DIRECTION_HORIZONTAL), | ||
| multiply( | ||
| this.gestureUntraversed, | ||
| I18nManager.isRTL ? MINUS_ONE_NODE : TRUE_NODE | ||
| ) | ||
| ), | ||
| this.gestureUntraversed |
There was a problem hiding this comment.
I figured out it's a bug here. We weren't updating this.gesture in vertical mode.
osdnk
commented
Oct 5, 2019
Comment on lines
+611
to
+617
| cond( | ||
| eq(this.direction, DIRECTION_HORIZONTAL), | ||
| multiply( | ||
| this.gestureUntraversed, | ||
| I18nManager.isRTL ? MINUS_ONE_NODE : TRUE_NODE | ||
| ), | ||
| this.gestureUntraversed |
There was a problem hiding this comment.
It was another bug here. In RTL we were multiplying a gesture in vertical mode as well.
osdnk
changed the title
satya164
approved these changes
Oct 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.