-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): build error on monorepo #560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Naturalclar
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, LGTM 🙏
Naturalclar
merged commit Apr 10, 2024
827305b
into
react-native-picker:master
2 of 12 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
## [2.7.5](v2.7.4...v2.7.5) (2024-04-10) ### Bug Fixes * **android:** build error on monorepo ([#560](#560)) ([827305b](827305b))
🎉 This PR is included in version 2.7.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
thanks @Naturalclar for the quick deployment. |
Kudo
added a commit
to expo/expo
that referenced
this pull request
Apr 10, 2024
# Why fix bridgeless support on android # How 1. set `newArchEnabled=true` on bare-expo 2. disable expo-updates which is blocked by #27996 3. patch @react-native-picker/picker which has a build error: react-native-picker/picker#560
tsapeta
pushed a commit
to expo/expo
that referenced
this pull request
Apr 11, 2024
# Why fix bridgeless support on android # How 1. set `newArchEnabled=true` on bare-expo 2. disable expo-updates which is blocked by #27996 3. patch @react-native-picker/picker which has a build error: react-native-picker/picker#560
tsapeta
pushed a commit
to expo/expo
that referenced
this pull request
Apr 12, 2024
# Why fix bridgeless support on android # How 1. set `newArchEnabled=true` on bare-expo 2. disable expo-updates which is blocked by #27996 3. patch @react-native-picker/picker which has a build error: react-native-picker/picker#560
alanjhughes
pushed a commit
to expo/expo
that referenced
this pull request
Apr 16, 2024
# Why fix bridgeless support on android # How 1. set `newArchEnabled=true` on bare-expo 2. disable expo-updates which is blocked by #27996 3. patch @react-native-picker/picker which has a build error: react-native-picker/picker#560
brentvatne
pushed a commit
to expo/expo
that referenced
this pull request
Apr 17, 2024
# Why fix bridgeless support on android # How 1. set `newArchEnabled=true` on bare-expo 2. disable expo-updates which is blocked by #27996 3. patch @react-native-picker/picker which has a build error: react-native-picker/picker#560
tsapeta
pushed a commit
to expo/expo
that referenced
this pull request
Apr 17, 2024
# Why fix bridgeless support on android # How 1. set `newArchEnabled=true` on bare-expo 2. disable expo-updates which is blocked by #27996 3. patch @react-native-picker/picker which has a build error: react-native-picker/picker#560
alanjhughes
pushed a commit
to expo/expo
that referenced
this pull request
Apr 17, 2024
# Why fix bridgeless support on android # How 1. set `newArchEnabled=true` on bare-expo 2. disable expo-updates which is blocked by #27996 3. patch @react-native-picker/picker which has a build error: react-native-picker/picker#560
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
having the error when building on android with new architecture enabled and in a monorepo:
How
the line should be referenced from other libraries but since the current npm package name is namespaced under
@react-native-picker/picker
, we should add more ".."Test Plan