Remove explicit SDK version for Windows builds #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
approved these changes
Mar 24, 2023
chrisglein
added a commit
to chrisglein/artificial-chat
that referenced
this pull request
Apr 13, 2023
See react-native-async-storage/async-storage#810 Update SDK logic based on PR feedback
chrisglein
force-pushed
the
sdkVersion
branch
from
0c2afae to
42349c8
Compare
TatianaKapos
approved these changes
Sep 14, 2023
jonthysell
approved these changes
Sep 14, 2023
jonthysell
approved these changes
Sep 18, 2023
1 task
Naturalclar
merged commit fc52bca
into
react-native-picker:master
10 of 12 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
## [2.5.1](v2.5.0...v2.5.1) (2023-09-20) ### Bug Fixes * Remove explicit SDK version for Windows builds ([#483](#483)) ([fc52bca](fc52bca))
|
🎉 This PR is included in version 2.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
chrisglein
added a commit
to chrisglein/artificial-chat
that referenced
this pull request
Sep 20, 2023
PR was merged react-native-picker/picker#483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix SDK build error if 10.0.18362.0 is not installed:
See react-native-async-storage/async-storage#810 for a similar fix.
Previously, after bringing down package dependencies you'd have to retarget the SDK version for the module project.
Test Plan
Committed to a fork and redirected an app with a Windows build to this. Build error goes away.