Ensuring unique URI when using copyTo: 'cachesDirectory' on android

[tamslinn]

Hi, I am using copyTo: 'cachesDirectory' which is working great on iOS - the file is copied to a uniquely named folder in NSCachesDirectory.

However on android the file is copied to `/data/user/0/[APPID]/cache/[FILENAME]. This means that if the user picks a second file with the same name, the first one is overwritten. My app processes the files from the cache dir and deletes them, but there is no way to guarantee that the user doesn't pick a second one with the same name before the first is processed. Is there a way to ensure the file gets a unique name in the cache directory on Android?

[vonovak]

hello, no, there is no way to do this, but I'm open to accepting a PR that defines the behavior for this - something that configures whether files are overwritten or created under unique name

[tamslinn]

I'll have a go... On iOS, the file is copied into a directory with a unique name (basically a uuid) within the cache directory, so the file name itself says the same. Would you be happy with the same approach?

[vonovak]

yes, so there will be an option to configure both approaches, and both should be supported on iOS and Android. Thank you!

[tamslinn]

On iOS I think it already puts the file in a uniquely named directory and there doesn't appear to be a configuration option for this.
(I'm not a native iOS developer, but I think that is what these lines of code are doing
https://github.com/rnmods/react-native-document-picker/blob/master/ios/RNDocumentPicker/RNDocumentPicker.m#L174)

I think on android I could do the same, so the file is copied to /data/user/0/[APPID]/cache/[UUID]/[FILENAME]. This way the filename stays the same. I can't think of any need to have a config option as it does not change the filename. Is that ok?

[vonovak]

oh, okay, I misunderstood and thought you wanted to have the option to overwrite those existing files, sorry. Sure, no config needed, then

[tamslinn]

Thanks - I have created a PR!