0.62.0 Discussion

[kelset]

Conversations on this thread are limited to 0.62 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.62.0 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

---

We have released this version to respect the work of hundreds of contributors who made this release possible and to prevent the release from falling too far behind master. Please be mindful of the reduced capacity of contributors to help with issues and prepare to delay upgrading if necessary.

[HarshitMadhav]

From all of us! Heartily Thanks to all the contributors who made this release possible in the time of Global Pandemic. Also, by this comment I would request all to 'Stay At Home' and follow your Government Policies.

[milo-]

Thank you for the amazing work getting this out in such difficult times. Would it be possible to get facebook/react-native#27574 backported into 0.62.x?

commit -> facebook/react-native@7a4753d

---

edited by @kelset to add link to commit

[jeveloper]

From the bottom of my heart (high and vulnerable) i want to wish all of you to be safe, healthy and close with other fellow humans. We're in this together across the world. Thank you and lots of love. The world will be bright again, more tollerant and accepting!

[farwayer]

Hi guys! We need to cherry-pick this commit facebook/react-native@cfcf5eb to prevent crash in release build on Android with hermes engine and enableProguardInReleaseBuilds enabled.

java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libhermes.so caused by: Didn't find class "com.facebook.jni.NativeRunnable" on path: DexPathList[[zip file "/data/app/com.alormi-0LUU5G6NefGa4kK5cebJ3A==/base.apk"],nativeLibraryDirectories=[/data/app/com.alormi-0LUU5G6NefGa4kK5cebJ3A==/lib/arm, /data/app/com.alormi-0LUU5G6NefGa4kK5cebJ3A==/base.apk!/lib/armeabi-v7a, /system/lib]]

ADDED. Look like it is actual for jsc too. Enabling proguard cause crash while app starting.
java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libfbjni.so caused by: Didn't find class "com.facebook.jni.NativeRunnable" on path: DexPathList[[zip file "/data/app/com.alormi-3XkDkUYd5FW63ZFsbLqHjQ==/base.apk"],nativeLibraryDirectories=[/data/app/com.alormi-3XkDkUYd5FW63ZFsbLqHjQ==/lib/arm, /data/app/com.alormi-3XkDkUYd5FW63ZFsbLqHjQ==/base.apk!/lib/armeabi-v7a, /system/lib]]

[ahce]

Hi! please pick this commit facebook/react-native@d3658bc
Thanks!

[kelset]

@kesha-antonov @soroushm please open issues in the main repo to report your problems (first ofc check if someone already reported them), and link them back here.

Also, if you think your issue may be related to upgrading, please refer to the new Upgrade Support repository.

[elicwhite]

Can we pick facebook/react-native@405200e

[kelset]

to cherry pick too: facebook/react-native@227aa96

[gorhom]

Hi 👋
could we pick facebook/react-native@576ddfb

[xiao99xiao]

This commit facebook/react-native@a5353c0 , I don't know why it's included in 0.61 but not in 0.62. Maybe because it's not added by PR so not on master?

Any way this commit is very important as it fixed this Modal issue facebook/react-native#26473

@kelset Could we cherry pick the commit and make sure it will not be absent again in the next big version like 0.63.0?

[alloy]

@xiao99xiao Those UIScene changes are not bug-fixes, so they won’t go into a patch release. They will be available in v0.63.0, though!

[timurgaitov]

If someone encounters errors while building the ios app, try updating cocoapods.

[kelset]

hey folks, quick update, we will try to get a 0.62.1 release out later today. For this patch release we will (likely*):

• cherry pick facebook/react-native@7a4753d

• cherry pick facebook/react-native@576ddfb

• cherry pick facebook/react-native@cfcf5eb

• cherry pick facebook/react-native@d3658bc

• cheery pick facebook/react-native@405200e

• won't cherry pick this facebook/react-native@227aa96 because it's been done directly on 0.62 branch hence it's already there :D

• to fix the modal support as reported by @xiao99xiao we will likely replicate the revert as a local commit (To Be Confirmed)

• same for Exclude all FlipperKit transitive dependencies from iOS Release builds facebook/react-native#28504 Decided to not do so and stick with a strict policy to not pick changes that have no landed yet in master

• bump RN CLI minor to the latest available version (4.5.1 at the time of writing) so that people get updated CLI without mangling with lock files

• Fix publishing from CI facebook/react-native@14b423e

• Port revert of Modal change to master and re-open original issue. Details are:

  Revert previous incomplete fix for an issue with Modal’s onDismiss prop.

* as always, it depends on the cherry picking process & our local testing to go well 🤞

---

LMK if I forgot anything

[xiao99xiao]

@kelset However this PR facebook/react-native#26490 is not a valid fix compared with the revert.

[alloy]

@kelset However this PR facebook/react-native#26490 is not a valid fix compared with the revert.

@xiao99xiao Can you please elaborate on exactly why not and what you’d suggest we should be doing instead?

[xiao99xiao]

@alloy OK. The key difference about the revert commit and the PR's solution is, the definition about dismiss on iOS.

On iOS, when we say a Modal is dismissed, it means the view is not visible and its view controller is removed from the parent view controller. And another important thing is, you could only present a new Modal after the earlier one's view controller is removed too.

The PR only watches on the visibility of the Modal view. However when the Modal view is not visible, its view controller could be not removed yet. Merging the PR will break one common logic that you need to present a Modal right after the previous one is dismissed.

So that's why I insist using the revert commit: The PR and its former commit facebook/react-native@bd2b7d6 are not right about dismiss and break too much.

[kelset]

Hey @xiao99xiao thank you a lot for your explanation 🙏

We've reached out to the author of the PR and he agrees with your assesment, so we will consider an alternative approach to solve the Modal issue (probably we will do the revert as you suggested in the first place).

I'll write an update here once we have done what above

[alloy]

Hey everybody, we just released v0.62.1: https://github.com/facebook/react-native/releases/tag/v0.62.1 🚀

You can see in @kelset’s comment what changes we applied or go directly to the CHANGELOG. Regarding the Model onDismiss prop we reverted the incorrect fix to be on par with v0.61.x.

As for other changes that were requested but not yet landed on master, we did not pick those as that’s not our policy 🙏

Thanks for all of your assistance and looking forward to continuing our collaborations on the v0.62.1 issue!