Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for the flashes when useNativeDriver={true} #116

Merged
merged 2 commits into from
Feb 22, 2018
Merged

Workaround for the flashes when useNativeDriver={true} #116

merged 2 commits into from
Feb 22, 2018

Conversation

peteroid
Copy link
Contributor

Workaround

  • add showContent to state for toggling the content in the modal
  • add hideModalContentWhileAnimating to props for using this workaround when useNativeDriver={true}

Credits

connect #92

@peteroid
Workaround for content flash
3c97cb6 
from Versus2017@0505665
@peteroid
Hide the content optionally
cdb5d02 
- add prop: `hideModalContentWhileAnimating`
@peteroid peteroid mentioned this pull request Feb 21, 2018
Closed
10 tasks
@mmazzarolo
Copy link
Member

@peteroid thank you so much for the clean workaround!

@mmazzarolo mmazzarolo merged commit b287b3f into react-native-modal:master Feb 22, 2018
@zhouyingkai1
Copy link

work well

@fonov
Copy link

fonov commented Jun 18, 2018

@peteroid Thanks so math!

@mrzie mrzie mentioned this pull request Aug 11, 2019
Closed
@rifansyah rifansyah mentioned this pull request Apr 22, 2021
Open
@thiagobrez thiagobrez mentioned this pull request Jul 10, 2023
Merged
57 tasks
@ikevin127 ikevin127 mentioned this pull request Nov 3, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peteroid @mmazzarolo @zhouyingkai1 @fonov