This repository has been archived by the owner on Jun 16, 2023. It is now read-only.
WIP: Implement video stabilization mode property for ios #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@n1ru4l good job, can you resolve the conflicts please? |
jgfidelis
approved these changes
Jun 4, 2018
sibelius
approved these changes
Jun 4, 2018
|
@n1ru4l you did not set a defaultProp, isn't this required? |
n1ru4l
commented
Jun 5, 2018
| @@ -441,6 +441,13 @@ - (void)record:(NSDictionary *)options resolve:(RCTPromiseResolveBlock)resolve r | |||
| [self updateSessionAudioIsMuted:!!options[@"mute"]]; | |||
|
|
|||
| AVCaptureConnection *connection = [self.movieFileOutput connectionWithMediaType:AVMediaTypeVideo]; | |||
| if (self.videoStabilizationMode != nil) { | |||
There was a problem hiding this comment.
@jgfidelis I think this should handle the case?
This was referenced Jun 6, 2018
luugiathuy
added a commit
to luugiathuy/react-native-camera
that referenced
this pull request
Jun 17, 2018
* master: (188 commits) 1.1.5 build(change-log): v1.1.5-2 Mock module and test a custom component using Jest (react-native-camera#1635) fix(rn-camera): fix codec backwards compat update zxing lib version [BUG, ANDROID] width prop not works correctly when fixOrientation is enabled (react-native-camera#1629) Update GradleUpgradeGuide.md (react-native-camera#1625) Docs around pause/resume preview (react-native-camera#1623) Added pause/resume preview functions to RNCamera (react-native-camera#1622) fix(picture-size): create None default value fix(rn-camera): fix types, conversions and casts WIP: Implement video stabilization mode property for ios (react-native-camera#1606) fix(picture-size): export method and change default value docs(expo): explain how to migrate to and from expo camera module (react-native-camera#1605) feat(preview): add android code feat(preview): add new props to JS ios-get-video-orientation-from-device-2 feat(preview): add preview methods and more fixes Update index.d.ts Bug/save to capture when app goes on pause (react-native-camera#1578) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows setting the property
videoStabilizationforiOSdevices.This is required for smoother video recordings.