Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use keyof #930

Open
MixusMinimax opened this issue Mar 2, 2023 · 0 comments · May be fixed by #981
Open

Use keyof #930

MixusMinimax opened this issue Mar 2, 2023 · 0 comments · May be fixed by #981

Comments

@MixusMinimax
Copy link

MixusMinimax commented Mar 2, 2023 •
edited
Loading

Existing Code

export interface SelectProps<ValueType = any, OptionType extends BaseOptionType = DefaultOptionType> extends BaseSelectPropsWithoutPrivate {
    //...
    optionFilterProp?: string;
}

Proposed Code

export interface SelectProps<ValueType = any, OptionType extends BaseOptionType = DefaultOptionType> extends BaseSelectPropsWithoutPrivate {
    //...
    optionFilterProp?: keyof OptionType;
}

This will give use better autocomplete.
@NextThread NextThread linked a pull request Sep 17, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added keyof in OptionFilterProp NextThread/select
1 participant
@MixusMinimax