fix: Group src order not correct when src updated #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/image/n6gxt09c8 |
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 229 230 +1
Branches 65 63 -2
=========================================
+ Hits 229 230 +1
Continue to review full report at Codecov.
|
afc163
approved these changes
Jan 20, 2021
AlanCutFlim
reviewed
Jan 20, 2021
| setPreviewUrls(oldPreviewUrls => { | ||
| const clonePreviewUrls = new Map(oldPreviewUrls); | ||
| const deleteResult = clonePreviewUrls.delete(id); | ||
| return deleteResult ? clonePreviewUrls : oldPreviewUrls; | ||
| }); | ||
| }; | ||
|
|
||
| // we don't to test this if canPreview changed when same url |
There was a problem hiding this comment.
Suggested change
| // we don't to test this if canPreview changed when same url | |
| // we don't need to test this if canPreview changed when url stays the same |
Maybe this is better👀
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close ant-design/ant-design#28881