-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add labelField and valueField for custom label field name and value field name #23
Conversation
I think your PR is useful for ant-design/ant-design#9929 Could you finish it and add some test cases? @405go |
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=========================================
+ Coverage 92.2% 92.4% +0.19%
=========================================
Files 3 3
Lines 154 158 +4
Branches 50 54 +4
=========================================
+ Hits 142 146 +4
Misses 12 12
Continue to review full report at Codecov.
|
@afc163 ok, i have finished |
How about |
@afc163 It is a good ideal |
@afc163 now it is good |
@afc163 It is our project style,It has become a habit. |
Add labelField and valueField for custom label field name and value field name, It is not should just use value and label