fix(NavbarOffcanvas): fix rendering of nav items when expand is used #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golota60
approved these changes
Apr 26, 2022
Comment on lines
+54
to
+74
| ref={ref} | ||
| show={!!context?.expanded} | ||
| bsPrefix={bsPrefix} | ||
| backdrop={backdrop} | ||
| backdropClassName={backdropClassName} | ||
| keyboard={keyboard} | ||
| scroll={scroll} | ||
| placement={placement} | ||
| autoFocus={autoFocus} | ||
| enforceFocus={enforceFocus} | ||
| restoreFocus={restoreFocus} | ||
| restoreFocusOptions={restoreFocusOptions} | ||
| onShow={onShow} | ||
| onHide={onHide} | ||
| onEscapeKeyDown={onEscapeKeyDown} | ||
| onEnter={onEnter} | ||
| onEntering={onEntering} | ||
| onEntered={onEntered} | ||
| onExit={onExit} | ||
| onExiting={onExiting} | ||
| onExited={onExited} |
There was a problem hiding this comment.
why change this from {...props}? Those props are being forwarded anyway
There was a problem hiding this comment.
lol yeah it's a bit ugly. I pulled it out because I also spread the remainder of the props into the div above for the navbar expand case.
kyletsang
force-pushed
the
fix-navbar-offcanvas
branch
from
fec2c67
to
75788fe
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6309
When the navbar hits the expand breakpoint, it will render the children into a div instead of using the Offcanvas component to do it. We don't need the functionality when the nav items are shown this way anyway. One thing that needs to be done is to add a default breakpoint size for xxl in @restart/hooks.
I think this approach should be ok? Will add tests later after review.