Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FormControl): Add support for html size attribute #5161

Merged
merged 1 commit into from
May 5, 2020

Conversation

Exxenoz
Copy link
Contributor

@Exxenoz Exxenoz commented May 5, 2020

Description
The commit of this PR adds support for the size attribute of select and input elements. This is especially useful in case someone wants to create a select table with multiple visible options. (Check https://www.w3schools.com/tags/att_select_size.asp for details.)

Changes

  • Added htmlSize prop to FormControl.js and linked it to the size attribute of the underlaying component.
  • Created a new test case in FormControlSpec.js to check if the html size attribute is properly set.
  • Updated forms doc and added an html size example to the "Select" section.

Related issue
#4499

@jquense jquense requested a review from kosmiq May 5, 2020 13:22
@taion taion merged commit 1ddd8c7 into react-bootstrap:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants