Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent parameters? #211

Open
shizhan1992 opened this issue Feb 27, 2020 · 0 comments
Open

inconsistent parameters? #211

shizhan1992 opened this issue Feb 27, 2020 · 0 comments

Comments

@shizhan1992
Copy link

cortex/cortex/built_ins/models/mine.py

Line 94 in 2837b22

self.mine.routine(generated, Z, generated, Z_P)

Hi, thank you for this great repository.
I am wondering if line 94 and line 111 are correct? shouldn't it be self.mine.routine(generated, generated, Z, Z_P)? because the routine accepts arguments in the order of "X_real, X_fake, Z_real, Z_fake".

Besides, line 123 "self.mine.visualize(generated, generated, Z, Z_N, targets)" seems correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shizhan1992