Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verified role is not added when user is already on server #236

Closed
Apexal opened this issue Jan 24, 2022 · 0 comments · Fixed by #242
Closed

Verified role is not added when user is already on server #236

Apexal opened this issue Jan 24, 2022 · 0 comments · Fixed by #242
Labels
bug Something isn't working Discord Interface Issues and PRs related to the Telescope Discord interface high priority Issues that should be given high priority

Comments

@Apexal
Copy link
Member

Apexal commented Jan 24, 2022

If a user has already joined the RCOS Discord server, the API call to add them to the server with the verified role has no effect. This results in the Verified role not getting added to the user.

Telescope/src/web/services/user/join_discord.rs

Line 95 in 5dad382

discord.add_to_rcos_guild(Some(nickname), roles).await?;

To fix, the API call to add the Verified role must be separated from the add to server API call.
@Apexal Apexal added bug Something isn't working high priority Issues that should be given high priority Discord Interface Issues and PRs related to the Telescope Discord interface labels Jan 24, 2022
@vcfxb vcfxb mentioned this issue Feb 2, 2022
Merged
@vcfxb vcfxb closed this as completed in #242 Feb 3, 2022
@Apexal Apexal mentioned this issue Jun 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Discord Interface Issues and PRs related to the Telescope Discord interface high priority Issues that should be given high priority
Projects
None yet
Milestone
No milestone
1 participant
@Apexal