Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private repositories in brew set_repo #84

Closed
radeksimko opened this issue Mar 5, 2019 · 2 comments
Closed

Support private repositories in brew set_repo #84

radeksimko opened this issue Mar 5, 2019 · 2 comments

Comments

@radeksimko
Copy link

Currently private repository is treated as "not found" during brew set_repo:

homebrew-file/bin/brew-file

Lines 1185 to 1192 in 9018246

url = "https://github.com/" + self.user_name() + "/" + self.repo_name()
# Check if the repository already exists or not.
exist_repo = True
try:
urlopen(url)
except HTTPError:
exist_repo = False

It would be great if there was a way to set a private repo.

The only way around I'm aware of is to temporarily make the repo public, run brew set_repo and make it private.

@radeksimko radeksimko changed the title Support private repositories Support private repositories in brew set_repo Mar 5, 2019
@rcmdnk
Copy link
Owner

rcmdnk commented Mar 6, 2019

Thank you for the report.

Yes, it should be available for private repositories as now GitHub provides them in free!

The new version v7.0.1 should work for the private repository, please try it.

@radeksimko
Copy link
Author

That was fast! Thanks for implementing it, I will give it a spin in upcoming day(s).

@rcmdnk rcmdnk closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants