Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more details in examples #99

Merged
merged 1 commit into from
Mar 6, 2024
Merged

more details in examples #99

merged 1 commit into from
Mar 6, 2024

Conversation

rcaneill
Copy link
Owner

@rcaneill rcaneill commented Mar 6, 2024

closes #95

@rcaneill rcaneill merged commit 81becdd into main Mar 6, 2024
12 checks passed
@rcaneill rcaneill deleted the issue95 branch March 6, 2024 11:19
Copy link
Contributor

@paigem paigem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion to include a link directly to the NEMO documentation if easy to do. Otherwise, this looks great - thanks!

docs/examples/compute_metrics.ipynb Show resolved Hide resolved
docs/examples/compute_metrics.ipynb Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add explanatory test to make the documentation examples more understandable
2 participants