Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check in node_modules in example folder #133

Closed
manurana opened this issue Oct 15, 2018 · 4 comments
Closed

Don't check in node_modules in example folder #133

manurana opened this issue Oct 15, 2018 · 4 comments

Comments

@manurana
Copy link

Thats bad practice. Let uses download and do a yarn install

@iThink32
Copy link
Contributor

@manurana our latest package does not have a node modules folder , I'm not sure what are you considering as a bad practice , can you throw more light on it?

@manurana
Copy link
Author

manurana commented Oct 16, 2018

Its in the /example folder @iThink32, as I have mentioned in the title .
The last commit 3cc182e added around 30K new files to the repo, most of which are at the path /example/node_modules.

@iThink32
Copy link
Contributor

iThink32 commented Oct 16, 2018

@manurana good point , it can be done using npm i , I just kept it there as there are certain steps to be followed to make react-native work on Xcode 10 as it unstable at the moment.Once react-native becomes stable on Xcode 10 , I will remove it.

have a look at this

facebook/react-native#19573

@iThink32
Copy link
Contributor

iThink32 commented Oct 17, 2018

@manurana thanks , closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants