-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't check in node_modules in example folder #133
Comments
@manurana our latest package does not have a node modules folder , I'm not sure what are you considering as a bad practice , can you throw more light on it? |
@manurana good point , it can be done using npm i , I just kept it there as there are certain steps to be followed to make react-native work on Xcode 10 as it unstable at the moment.Once react-native becomes stable on Xcode 10 , I will remove it. have a look at this |
@manurana thanks , closing due to inactivity. |
Thats bad practice. Let uses download and do a
yarn install
The text was updated successfully, but these errors were encountered: