Bug after making payment through net banking

[jonathanjr3]

Description

A "Payment Successful" page shows up after making a payment through Netbanking which doesn't dismiss itself automatically:

Clicking on "Cancel" here doesn't dismiss the page either:

As a workaround we are getting the top most view controller and dismissing it manually inside the onPaymentSuccess delegate method of RazorpayPaymentCompletionProtocol

This workaround doesn't work when the "Success" button here is tapped twice quickly, the "Payment Successful" page just stays there:

All of this were tested in testing environment, we haven't checked this in production yet. The payment itself is working fine, only the payment successful page is not getting dismissed automatically.
This was working fine till razorpay version 1.3.2

Razorpay pod Version :

Version 1.3.3

Xcode Version :

14.3.1 (14E300c)

What you did:

• Choose 'Netbanking' for payment mode in the razorpay payment page
• Choose any bank
• Click on 'Success' in the demo bank page

What happened:

• A 'Payment Successful' page shows up and doesn't get dismissed automatically

Steps To Reproduce

Provide a detailed list of steps that reproduce the issue.

1. Intialize RazorpayCheckout object with RazorpayCheckout.initWithKey(razorpayAPIKey, andDelegate: self)
2. Open payment view with razorpay.open(params, displayController: self)
3. Choose 'Netbanking' for payment mode in the razorpay payment page
4. Choose any bank
5. Click on 'Success' in the demo bank page

Suggested solution:

• Get the top most view controller and dismiss it manually inside the onPaymentSuccess delegate method of RazorpayPaymentCompletionProtocol
• Note that this doesn't work when the 'Success' button is tapped twice quickly in the 'demo bank' page

Code example, screenshot, or link to a repository:

var param = [String: Any]()
param["name"] = "NameOfCompany"
param["currency"] = currencyvalue
param["order_id"] = orderId
        
var prefill = [String: Any]()
prefill["name"] = firstname
prefill["email"] = email
prefill["contact"] = mobile
param["prefill"] = prefill
        
var notes = [String: Any]()
notes["order_id"] = orderId
param["notes"] = notes
        
var theme = [String: Any]()
theme["image_frame"] = false
param["theme"] = theme
let razorpay = RazorpayCheckout.initWithKey(razorpayAPIKey, andDelegate: self)
razorpay.open(param, displayController: self)