Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming IndexedParallelIterator::collect_into #519

Closed
cuviper opened this issue Jan 29, 2018 · 2 comments
Closed

Consider renaming IndexedParallelIterator::collect_into #519

cuviper opened this issue Jan 29, 2018 · 2 comments

Comments

@cuviper
Copy link
Member

cuviper commented Jan 29, 2018

rust-lang/rust#45840 is proposing an Iterator::collect_into for any Extend type, different than our IndexedParallelIterator::collect_into that truncates and collects into a Vec. I think Iterator::unzip_into is also something that could reasonably added for symmetry.

It would be unfortunate to have this mismatch long-term, but it's too early to know if std will really add this, or what shape it will take. Maybe we can find a more specific "indexed" name that's less likely to ever have a conflict with std.

@nikomatsakis
Copy link
Member

collect_into_vec?

@cuviper
Copy link
Member Author

cuviper commented Feb 2, 2018

Fixed in #521.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants