Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable serde on playground #102

Closed
masklinn opened this issue Apr 3, 2024 · 3 comments · Fixed by #103
Closed

Enable serde on playground #102

masklinn opened this issue Apr 3, 2024 · 3 comments · Fixed by #103

Comments

@masklinn
Copy link
Contributor

masklinn commented Apr 3, 2024 •
edited
Loading

Either is on the playground, and has a serde feature which can be quite useful to use, test, and play around with, but it's not enabled by default.

The playground allows defining some metadata, especially related to features: rust-lang/rust-playground#192 (comment)

Maybe it'd be possible to add that to Cargo.toml to enable a more complete set of features when on playground?
@jswrenn
Copy link
Collaborator

jswrenn commented Apr 3, 2024

This is a very good idea. Would you like to file a PR doing so?

@masklinn
Copy link
Contributor Author

masklinn commented Apr 3, 2024

This is a very good idea. Would you like to file a PR doing so?

Sure thing.

@masklinn masklinn mentioned this issue Apr 4, 2024
Merged
@masklinn
Copy link
Contributor Author

masklinn commented Apr 4, 2024

This is a very good idea. Would you like to file a PR doing so?

Opened #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable serde feature on playgrounds masklinn/either
2 participants
@masklinn @jswrenn