zopsmart#3 | in case of error, nil returned instead of any string at …

…http layer
raybittu · Feb 15, 2021 · a472e13 · a472e13
1 parent ca3f5da
commit a472e13
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/panel/http/http.go b/panel/http/http.go
@@ -21,14 +21,14 @@ func New(service service.PanelEmployee) PanelHTTP {
 func (p PanelHTTP) CreateEmployee(c *gofr.Context) (interface{}, error) {
 	companyID, err := strconv.Atoi(c.Request.PathParam("companyID"))
 	if err != nil {
-		return "Invalid CompanyID", customError.ErrInvalidCompanyID
+		return nil, customError.ErrInvalidCompanyID
 	}
 	var emp models.Employee
 
 	err = c.Request.Bind(&emp)
 
 	if err != nil {
-		return "Wrong json format", customError.ErrJSONFormat
+		return nil, customError.ErrJSONFormat
 	}
 
 	res, err := p.service.CreateEmployee(c, companyID, &emp)
@@ -43,7 +43,7 @@ func (p PanelHTTP) CreateEmployee(c *gofr.Context) (interface{}, error) {
 func (p PanelHTTP) GetAllEmployee(c *gofr.Context) (interface{}, error) {
 	companyID, err := strconv.Atoi(c.Request.PathParam("companyID"))
 	if err != nil {
-		return "Invalid CompanyID", customError.ErrInvalidCompanyID
+		return nil, customError.ErrInvalidCompanyID
 	}
 
 	yoe, _ := strconv.Atoi(c.Param("yoe"))