Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Add an example for RAY_DEDUP_LOGS_SKIP_REGEX #47913

Merged
merged 6 commits into from
Oct 16, 2024
Merged

[core] Add an example for RAY_DEDUP_LOGS_SKIP_REGEX #47913

merged 6 commits into from
Oct 16, 2024

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Oct 6, 2024 •
edited
Loading

Why are these changes needed?

A customer wanted to configure RAY_DEDUP_LOGS_SKIP_REGEX by herself, but failed. The reasons are:

  • She didn't know the env var needs to be set on the driver process. Instead, she uses runtime env to set the env var.
  • She didn't know the env var needs to be set before import ray.
image

Related issue number

Closes #47926

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kevin85421
update
c411d0c 
Signed-off-by: kaihsun <[email protected]>
@kevin85421 kevin85421 marked this pull request as ready for review October 7, 2024 22:16
@kevin85421 kevin85421 requested a review from a team as a code owner October 7, 2024 22:16
@kevin85421 kevin85421 assigned kevin85421 and jjyao and unassigned jjyao and kevin85421 Oct 7, 2024
@kevin85421
update
18387da 
Signed-off-by: kaihsun <[email protected]>
MengjinYan
MengjinYan approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@MengjinYan MengjinYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

@kevin85421 kevin85421 assigned MengjinYan and unassigned jjyao Oct 10, 2024
angelinalg
angelinalg reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits to clarify passive voice sentences.

@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Oct 14, 2024
@MengjinYan MengjinYan mentioned this pull request Oct 15, 2024
Open
angelinalg
angelinalg approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjyao jjyao merged commit 84fde99 into ray-project:master Oct 16, 2024
5 checks passed
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
@kevin85421 @Jay-ju
[core] Add an example for RAY_DEDUP_LOGS_SKIP_REGEX (ray-project#47913
9fd9c52 
)

Signed-off-by: kaihsun <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@kevin85421 @mohitjain2504
[core] Add an example for RAY_DEDUP_LOGS_SKIP_REGEX (ray-project#47913
a4cbb91 
)

Signed-off-by: kaihsun <[email protected]>
Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Superskyyy Superskyyy Superskyyy left review comments

@MengjinYan MengjinYan MengjinYan approved these changes

@angelinalg angelinalg angelinalg approved these changes

Assignees

@MengjinYan MengjinYan

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] Add an example for RAY_DEDUP_LOGS_SKIP_REGEX
5 participants
@kevin85421 @MengjinYan @Superskyyy @angelinalg @jjyao