[Fix][Dashboard] Fix Place Group Table table cells overflow #47323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevin85421 PTAL |
MortalHappiness
force-pushed
the
bugfix/#47315-dashboard-text-clipped
branch
from
e2c0099 to
320d8df
Compare
|
@alanwguo would you mind taking a look? Thanks! |
anyscalesam
added
dashboard
alanwguo
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Thanks for the fix. The approach looks good.
@scottsun94 , can you review the UX design?
| overflow: "hidden", | ||
| textOverflow: "ellipsis", | ||
| width: "100%", | ||
| whiteSpace: "nowrap", |
There was a problem hiding this comment.
this rowStyles is it used by multiple tables? Have you verified if other tables don't break their layout due to this change?
There was a problem hiding this comment.
This style is used in
So change this style can fix them all.
Before:
After:
|
Thanks for the PR! RE the design, can we make it a bit simpler?
|
MortalHappiness
force-pushed
the
bugfix/#47315-dashboard-text-clipped
branch
from
2fd994d to
e5ac7f4
Compare
|
@scottsun94 I've updated the design. See the following video for details. pr47323.mp4 |
|
@MortalHappiness Cool. LGTM. Thanks! |
|
cc @alanwguo does the code change look good to you? |
Closes: ray-project#47315 Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#47315 Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#47315 Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
force-pushed
the
bugfix/#47315-dashboard-text-clipped
branch
from
e5ac7f4 to
c645923
Compare
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…ect#47323) Signed-off-by: Chi-Sheng Liu <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…ect#47323) Signed-off-by: Chi-Sheng Liu <[email protected]> Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See the description in the corresponding issue for details.
In this PR, the ID will never be cut, and the bundles will display differently according to the array length.
Before:
After:
-)Related issue number
Closes: #47315
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.