Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] __init__ functions have no return values #47144

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

aslonnie
Copy link
Collaborator

even for serve deployments

@aslonnie aslonnie requested review from GeneDer and edoakes August 14, 2024 22:30
@aslonnie
Copy link
Collaborator Author

start of lonnie's daily lint fix in ray repo..

@aslonnie aslonnie force-pushed the lonnie-240814-lint branch from 731dba1 to 93b06be Compare August 14, 2024 22:31
even for serve deployments

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie force-pushed the lonnie-240814-lint branch from 93b06be to 89ffb48 Compare August 14, 2024 22:32
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aslonnie aslonnie enabled auto-merge (squash) August 14, 2024 22:42
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 14, 2024
@github-actions github-actions bot disabled auto-merge August 15, 2024 00:12
@aslonnie aslonnie merged commit e21af4b into master Aug 15, 2024
5 checks passed
@aslonnie aslonnie deleted the lonnie-240814-lint branch August 15, 2024 01:27
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Aug 15, 2024
even for serve deployments

Signed-off-by: Lonnie Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants