From df45d54c60227c95d4826779de9292ed68542a89 Mon Sep 17 00:00:00 2001 From: Chris Wong Date: Thu, 30 Sep 2021 09:43:11 -0700 Subject: [PATCH 1/5] skip test_wrapped_actor_creation on windows --- python/ray/tests/test_client.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/ray/tests/test_client.py b/python/ray/tests/test_client.py index 1b920eaf91b2..26dfdd59318f 100644 --- a/python/ray/tests/test_client.py +++ b/python/ray/tests/test_client.py @@ -708,6 +708,7 @@ def test_object_ref_cleanup(): assert result == "" +@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.") @pytest.mark.parametrize( "call_ray_start", ["ray start --head --ray-client-server-port 25552 --port 0"], From 3a3c46560c282e38d383dcdfb9a9e9c0ec01a2ec Mon Sep 17 00:00:00 2001 From: Chris Wong Date: Thu, 30 Sep 2021 09:55:40 -0700 Subject: [PATCH 2/5] rerun windows ci From c7527c85c3ceaba2692290c73b90dd9f6beb92d4 Mon Sep 17 00:00:00 2001 From: Chris Wong Date: Tue, 5 Oct 2021 13:31:26 -0700 Subject: [PATCH 3/5] mark test_valid_actor_state_2 as flaky --- python/ray/tests/test_client_reconnect.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/ray/tests/test_client_reconnect.py b/python/ray/tests/test_client_reconnect.py index c70540d63194..ba1fe847fd33 100644 --- a/python/ray/tests/test_client_reconnect.py +++ b/python/ray/tests/test_client_reconnect.py @@ -332,6 +332,7 @@ def fail_every_seven(_): assert ray.get(ref) == 100 +@pytest.mark.skipif(sys.platform == "win32", reason="Flaky on windows") def test_valid_actor_state_2(): """ Do a full disconnect (cancel channel) every 11 requests. Failure From 5e3f2770ae1698de691d7d2de34fc39763413b4c Mon Sep 17 00:00:00 2001 From: Chris Wong Date: Tue, 5 Oct 2021 13:35:51 -0700 Subject: [PATCH 4/5] mark test_valid_actor_state --- python/ray/tests/test_client_reconnect.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/ray/tests/test_client_reconnect.py b/python/ray/tests/test_client_reconnect.py index ba1fe847fd33..0672b755f9eb 100644 --- a/python/ray/tests/test_client_reconnect.py +++ b/python/ray/tests/test_client_reconnect.py @@ -294,6 +294,7 @@ def disconnect(middleman): disconnect_thread.join() +@pytest.mark.skipif(sys.platform == "win32", reason="Flaky on windows") def test_valid_actor_state(): """ Repeatedly inject errors in the middle of mutating actor calls. Check From c1f8e0212968dc9944e87226eb34402736d47841 Mon Sep 17 00:00:00 2001 From: Chris Wong Date: Tue, 5 Oct 2021 14:52:41 -0700 Subject: [PATCH 5/5] rerun